[David Michael via Gnupg-devel] [PATCH libgcrypt 1/2] cipher/sha512: Fix non-NEON ARM assembly implementation

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[David Michael via Gnupg-devel] [PATCH libgcrypt 1/2] cipher/sha512: Fix non-NEON ARM assembly implementation

GnuPG - Libgcrypt - Dev mailing list
* cipher/sha512.c (do_transform_generic)
[USE_ARM_ASM]: Switch to the non-NEON assembly implementation.

--

When building for ARM CPUs that don't support NEON, linking fails
with an "undefined reference to _gcry_sha512_transform_armv7_neon"
error.  Switching to the non-NEON assembly function corrects this.
---

(Resending this in case it wasn't delivered due to not being subscribed.)

 cipher/sha512.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cipher/sha512.c b/cipher/sha512.c
index f70cdf42..0f4c304f 100644
--- a/cipher/sha512.c
+++ b/cipher/sha512.c
@@ -291,7 +291,7 @@ static unsigned int
 do_transform_generic (void *context, const unsigned char *data, size_t nblks)
 {
   SHA512_CONTEXT *hd = context;
-  return _gcry_sha512_transform_armv7_neon (&hd->state, data, k, nblks);
+  return _gcry_sha512_transform_arm (&hd->state, data, k, nblks);
 }
 #else
 static unsigned int
--
2.26.2

_______________________________________________
Gnupg-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gnupg-devel




--
* Free Assange and protect free journalism!
* Germany: Sign the Treaty on the Prohibition of Nuclear Weapons!

_______________________________________________
Gcrypt-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel

signature.asc (233 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [David Michael via Gnupg-devel] [PATCH libgcrypt 1/2] cipher/sha512: Fix non-NEON ARM assembly implementation

Jussi Kivilinna-2
Hello,

On 22.1.2021 13.19, Werner Koch via Gcrypt-devel wrote:

> ForwardedMessage.eml / David Michael <[hidden email]>:
>
> * cipher/sha512.c (do_transform_generic)
> [USE_ARM_ASM]: Switch to the non-NEON assembly implementation.
>
> --
>
> When building for ARM CPUs that don't support NEON, linking fails
> with an "undefined reference to _gcry_sha512_transform_armv7_neon"
> error.  Switching to the non-NEON assembly function corrects this.
> ---
>
(Resending this in case it wasn't delivered due to not being subscribed.)
>
Looks correct. Thanks.

-Jussi

_______________________________________________
Gcrypt-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel