[PINENTRY PATCH] tty button-related fixes and refinements

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PINENTRY PATCH] tty button-related fixes and refinements

Ineiev
Hello,

I attach some fixes I've come up with when playing with non-ASCII
texts in buttons.

The first one simplifies key checking code a little bit; the second
one fixes a few bugs in underscore processing; the third one lets
the user see the localized message even if the pinentry doesn't
support its accelerators (by the way, I think that pinentry
should localize the messages that aren't customized from the agent,
like "Press any key to continue."); the last one adds a default
message to a call of button() so that pinentry won't skip a button
when its text is localized.

Thank you!

_______________________________________________
Gnupg-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

0001-tty-Refactor-usage-of-tolower.patch (2K) Download Attachment
0002-tty-Fix-underscore-processing-in-accelerators.patch (1K) Download Attachment
0003-tty-Show-supplied-message-when-using-default.patch (2K) Download Attachment
0004-tty-Avoid-using-button-with-NULL-default-text.patch (958 bytes) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PINENTRY PATCH] tty button-related fixes and refinements

Ineiev
Hello,

On Fri, Apr 08, 2016 at 01:47:38PM -0400, Ineiev wrote:

>
> I attach some fixes I've come up with when playing with non-ASCII
> texts in buttons.
>
> The first one simplifies key checking code a little bit; the second
> one fixes a few bugs in underscore processing; the third one lets
> the user see the localized message even if the pinentry doesn't
> support its accelerators (by the way, I think that pinentry
> should localize the messages that aren't customized from the agent,
> like "Press any key to continue."); the last one adds a default
> message to a call of button() so that pinentry won't skip a button
> when its text is localized.
I've fixed a few typos in comments and log messages.

Thank you!

_______________________________________________
Gnupg-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

0001-tty-Refactor-usage-of-tolower.patch (2K) Download Attachment
0002-tty-Fix-underscore-processing-in-accelerators.patch (1K) Download Attachment
0003-tty-Show-supplied-message-when-using-default.patch (2K) Download Attachment
0004-tty-Avoid-using-button-with-NULL-default-text.patch (959 bytes) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PINENTRY PATCH] tty button-related fixes and refinements

NIIBE Yutaka
On 09/27/2016 01:02 PM, Ineiev wrote:

> On Fri, Apr 08, 2016 at 01:47:38PM -0400, Ineiev wrote:
>>
>> I attach some fixes I've come up with when playing with non-ASCII
>> texts in buttons.
>>
>> The first one simplifies key checking code a little bit; the second
>> one fixes a few bugs in underscore processing; the third one lets
>> the user see the localized message even if the pinentry doesn't
>> support its accelerators (by the way, I think that pinentry
>> should localize the messages that aren't customized from the agent,
>> like "Press any key to continue."); the last one adds a default
>> message to a call of button() so that pinentry won't skip a button
>> when its text is localized.
>
> I've fixed a few typos in comments and log messages.
Thank you for your fixes.

I applied three bug fixes, with commit message edit by me.

    0001-tty-Refactor-usage-of-tolower.patch
    0002-tty-Fix-underscore-processing-in-accelerators.patch
    0004-tty-Avoid-using-button-with-NULL-default-text.patch

For 0001, I modified your change a bit to keep the output for input
key is as same as before.

The patch:

    0003-tty-Show-supplied-message-when-using-default.patch

is introducing a new feature.  Let me have (more) time to review this
closely.
--


_______________________________________________
Gnupg-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

signature.asc (465 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PINENTRY PATCH] tty button-related fixes and refinements

Ineiev
On Mon, Oct 03, 2016 at 04:06:29PM +0900, NIIBE Yutaka wrote:
>
> I applied three bug fixes, with commit message edit by me.
>
>     0001-tty-Refactor-usage-of-tolower.patch
>     0002-tty-Fix-underscore-processing-in-accelerators.patch
>     0004-tty-Avoid-using-button-with-NULL-default-text.patch

Thank you!

> For 0001, I modified your change a bit to keep the output for input
> key is as same as before.

Indeed, I could have written that part more carefully.

> The patch:
>
>     0003-tty-Show-supplied-message-when-using-default.patch
>
> is introducing a new feature.  Let me have (more) time to review this
> closely.

It may be thought of as a new feature, but I think it's essential
for making pinentry work reliably, especially when the translator
doesn't care of pinentry-tty.

_______________________________________________
Gnupg-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PINENTRY PATCH] tty button-related fixes and refinements

Ineiev
On Mon, Oct 03, 2016 at 11:49:52AM -0400, Ineiev wrote:

>
> > The patch:
> >
> >     0003-tty-Show-supplied-message-when-using-default.patch
> >
> > is introducing a new feature.  Let me have (more) time to review this
> > closely.
>
> It may be thought of as a new feature, but I think it's essential
> for making pinentry work reliably, especially when the translator
> doesn't care of pinentry-tty.
Rebased against current HEAD.

_______________________________________________
Gnupg-devel mailing list
[hidden email]
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

0001-tty-Show-supplied-message-when-using-default.patch (2K) Download Attachment
signature.asc (499 bytes) Download Attachment